Add smb folder without restarting service

Jhonattan_Godoy_LorD · November 22, 2018, 8:10pm

Good afternoon,
how can I create shared folders in SMB and not restart the service, since if I have active transfers these are dropped

Haioken · November 22, 2018, 10:09pm

I know that Samba can be instructed to reload the config with a sighup:

killall -HUP smbd

However, I’m unsure of how Rockstor manages share creation (and am not near my box at the moment to test)
It’s possible that the Rockstor interface fully restarts the service.

phillxnet · November 23, 2018, 12:04pm

@Haioken I can chip in on the following point after a quick look at the code:

we have (when adding a share):

github.com

rockstor/rockstor-core/blob/master/src/rockstor/storageadmin/views/samba.py#L162-L164


refresh_smb_config(list(SambaShare.objects.all()))
self._restart_samba()
return Response(SambaShareSerializer(smb_share).data)

where if the systemctl status of first smb and then nmb have a return code of 0,

github.com

rockstor/rockstor-core/blob/master/src/rockstor/system/services.py#L148-L153


elif (service_name == 'smb'):
    out, err, rc = run_command([SYSTEMCTL_BIN, 'status', 'smb'],
                               throw=False)
    if (rc != 0):
        return out, err, rc
    return run_command([SYSTEMCTL_BIN, 'status', 'nmb'], throw=False)

read by _restart_samba()

github.com

rockstor/rockstor-core/blob/master/src/rockstor/storageadmin/views/samba.py#L49-L53


@staticmethod
def _restart_samba():
    out = status()
    if (out[2] == 0):
        restart_samba(hard=True)

Where the hard restart is a restart, rather than a reload:

github.com

rockstor/rockstor-core/blob/master/src/rockstor/system/samba.py#L219-L227


def restart_samba(hard=False):
"""
call whenever config is updated
"""
mode = 'reload'
if (hard):
    mode = 'restart'
run_command([SYSTEMCTL, mode, 'smb'])
return run_command([SYSTEMCTL, mode, 'nmb'])

So on a cursory look it would seem we have provision for a config reload but in the 2 direct calls of restart_samba() they are both hard wired to restart ie (hard=True) and one of those is for a config change:

github.com

rockstor/rockstor-core/blob/master/src/rockstor/smart_manager/views/samba_service.py#L48-L55


@transaction.atomic
def post(self, request, command):
    """
    execute a command on the service
    """
    service = Service.objects.get(name=self.service_name)


    if (command == 'config'):

where we find:

github.com

rockstor/rockstor-core/blob/master/src/rockstor/smart_manager/views/samba_service.py#L91-L93


self._save_config(service, global_config)
update_global_config(global_config, adconfig)
restart_samba(hard=True)

So it may be we have an overkill bug here where we could use our own hard=False default for some samba actions.

It would need more looking into, ie how this relates to active directory for example, as those last 2 code excepts are close to code that considers active directly configs. It might be good to open an issue on this once we have proved reload’s capability in some of our existing settings as, from a quick look, I suspect it was intended to reload sometime when we are actually restarting.

Thanks @Jhonattan_Godoy_LorD and @Haioken for bringing attention to this. It would be a nice refinement to pin down. I can’t adopt this one myself for a bit however as I’ve got a bit of a backlog.