@Richie Welcome to the Rockstor community. Chuffed you fancy doing some development by the way.
What you’ve done looks to be good although I’d get distro via the python-distro package as that’s how I tested it, we need the site install but the build process, from tag 3.9.2-45 onwards, also pip installs for our virtual env as well). It has to exist in both. Not related but just a note. See my notes on this and the change I made to base-buildout.cfg in the following pull request which was merged recently and constitutes git tag 3.9.2-45 (as yet unreleased in rpm form).
Anyway I’m not sure what’s happening with your build but I strongly suspect you still have the original rpm installed. So I would make sure you first delete that. You’ve not build in /opt/rockstor which is good so I say uninstall the rockstor rpm then wipe the /opt/rockstor dir so you are certain there is nothing running from there. I’d also delete all you have as well and build again fresh, just in case. Also note that the rockstor-pre service does a bunch of pre-config (via it’s invoking initrock) so make sure you stop those services (which are probably still from the rpm) then after the build they will be started automatically again and so the config that it sets up will pertain to the new source build dir (your /opt/rockstor-git) not the rpm installed one (/opt/rockstor).
Quick note on work in progress, to avoid us standing on each others toes or duplicating effort: @Flox is in progress making some significant additions / changes to the Rockon system. If it relates to your plans then he would be the best person to speak to on that, ie in this thread or via private message if that works for both parties. @phillxnet (me) is in progress making significant changes to the disk delete mechanism and I’ve also reworked how we refresh our disks and pools (mostly for performance improvements / efficiencies). So you might want to avoid making changes in those areas at least until we have our respective pull request in as it would be a real shame, and disheartening, if our efforts clashed. The above is what I’m currently aware of anyway.
My current issue relating to the above (for me) is:
which I’ve essentially fixed but got carried away with some much needed optimisations / rationalisations re the disk / pool management as whenever a balance is kicked off we really struggle with interactivity: hence the efficiency drive (made some fairly substantial time savings as it goes).
And I’ve also in the process fixed:
by adding (locally only so far) btrfs per disk allocation tracking / surfacing, as well as an embryonic devid tracker. We needed this to make more relevant calculations on that latter issue.
You might also want to take heed of out plans re openSUSE Leap 15.0 / Tumbleweed which a good part of my last 6 months has been prepping the code for; see:
So if you do end up making any changes it would be most appreciated to ensure that those changes work also when building on those distros, just to avoid holding up that move really, but Rockstor on those distros is still very much a work in progress and our main platform is still CentOS. But not worries otherwise as it’s a bit much working across 3 distros concurrently and hopefully what every you do will be OK anyway (really depends on how close to the OS you work at): but just to keep that in mind would be good. Also they run a far newer btrfs-progs and back port a tone of btrfs kernel stuff so if your interests is at that level then also worth bearing in mind.
Hopefully that has been helpful and I haven’t missed the mark. And if all is well you should have a shiny new build running as expected shortly. Let us know how you get on and any ideas on the areas you fancy working on may also help us to pick issues that are less likely to clash. Have fun.
Oh one other thing, You may also need to incorporate the changes in the following pr:
Just a single line change to account for an upstream update that broke our build.