Add a "default_value" to the Environment Object of Rockon conf file

Flox · January 19, 2023, 3:11pm

Hi @aremiaskfa,
Thanks a lot for your detailed feedback, always a pleasure to see that .

@stitch10925, thank you for your feedback as well.

I too, agree with both of you and think that it would be an important improvement overall. This was also a feature brought up by @magicalyak that we unfortunately had to leave unattended for too long now ; see below:

This issue is also somewhat related and linked to another improvement: being able to make env configuration optional…

github.com/rockstor/rockstor-core

Rockons: Ability to set environment objects as optional

opened 12:10AM - 30 Nov 19 UTC

Hooverdan96

this is out of the discussion in this thread: https://forum.rockstor.com/t/de…fault-values-for-environment-variables-in-rockon-definition/6512 Currently environment variables are required, i.e. if they are defined as part of the json file, then during the installation/configuration of the RockOn, they have to be populated. Especially for Rockons based on docker images that use environment variables to pass specific options to the API of the image application, this would be useful. @FroggyFlox already has mentioned an idea on how to represent this in the json file: simple key:value under the specific environment object to set an "optional": true/false flag. Behavior when the json file is ingested: If set to true, the given environment variable can be left blank during the rock-on install wizard. And if it's left blank it will not be part of the docker run command that is generated to launch the RockOn. In order to keep backwards compatibility, if this key:value pair doesn't exist (or is set to false), the original behavior of requiring to maintain the environment object during the install wizard.

(see also issue #2280)
… that originated from one of @Hooverdan’s ideas:

A lot to improve here and a lot of backlog, unfortunately. Now that we’re getting closer to having our next Stable release situated, though (see First Stable Poetry build Milestone · GitHub), I am hopeful we will be able to spend more effort on such changes that require some database alteration(s).

Let us know if any of you is interested in having a go at those and we’ll do all we can to assist/support along the way, of course!