suman
February 23, 2016, 6:32am
22
We just released 3.8-11.16 and I think we are getting pretty close to the next stable update. please test away!
opened 02:49AM - 27 Aug 15 UTC
closed 06:00AM - 23 Feb 16 UTC
enhancement
I just set up alert e-mails through the RockStor web interface (running version … 3.8-6), and it let me specify the mail server address but wouldn't let me specify a port, it is apparently hard coded to 587. My mail server only runs on port 25 internally (I forward 587 to it on the firewall), so I had to hand edit the Postfix configuration to get it to work. Now I certainly could also change my mail server config, but it would be nice if the web interface simply had an option to specify a custom port.
suman
February 24, 2016, 8:45pm
24
Hello everyone, 3.8-11.17 is now available. We’ve fixed up a few minor bugs that came up in testing and reported by users as well. The special thing about this update is that we have a new contributor !
rockstor:master ← nicolaslt:undefvarrockonstart
opened 07:07AM - 20 Feb 16 UTC
A console.log trying to log an undefined var was preventing the user to be able … to restart a stopped rock-on from the web ui.
opened 08:49AM - 20 Feb 16 UTC
closed 03:22PM - 13 Apr 16 UTC
bug
Hi,
After creating a share, when going back to it via the 'edit' button, some -… if not most- of the inputs do not display the correct data. Example: Read Only always stays on yes.
I was on my way to make a pull request for this but it seems to me this page needs more work. I'm happy to do that extra work if we agree it's needed.
There are many duplications in the .jst as follow:
``` handlebars
{{#if sambaShareIdNotNull}}
<input type="text" id="comment" class="form-control" name="comment" value="{{smbShareComment}}" title="Comment string to associate with the new share">
{{else}}
<input type="text" id="comment" class="form-control" name="comment" value="Samba-Export" title="Comment string to associate with the new share">
{{/if}}
```
which IMHO should be:
``` handlebars
<input type="text" id="comment" class="form-control" name="comment" value="{{smbShareComment}}" title="Comment string to associate with the new share" placeholder="Samba-Export">
```
And the javascript defines 5 handlebar helpers to render 3 yes/no radio buttons and 2 selects. Couple of bullets for this:
- I guess the yes/no radios should be checkboxes
- Those helpers defeat the purpose of having a templating engine. Why not use a handlebar partial instead ? Especially as the helpers duplicate the code by quite a bit. Each yes/no helper has 4 lines of html. (1 per permutation between `checked` and the option `name` and `value`)
- This is where the original issue comes from; there's a few `this` and scope confusion in the building of the yes/no radios.
suman
February 25, 2016, 8:41pm
27
Nice observation. you are right! and the behavior is unintentional. I’ve created this issue to improve it. Thanks for reporting it.
suman
February 25, 2016, 8:47pm
28
3.8-11.18 is now available! We are introducing a better(searchable and sortable) pagination for services view based on jquery datatables. We look forward to updating other tables as well, perhaps in the next cycle.
opened 06:04PM - 16 Aug 15 UTC
closed 08:45PM - 25 Feb 16 UTC
enhancement
This has been overdue for a while anyway, and here's a relevant user comment:
T… he "on/off" switch graphic is hard to spot check when there's a bunch of them, like on the services page.
suman
February 26, 2016, 2:16am
29
3.8-11.20 is the last update available on the testing channel. Stable release 3.8-12 is now available!
Thanks to all of you for actively testing and reporting issues. We still have a long way to go. Hope to see you in the next cycle!