Issue: Schedules broken after update to 3.9.2-0

@ScarabMonkey and @Flox

As @Flox points out there were large but necessary API changes towards the end of 3.9.1’s development cycle (3.9.0-13 pool api and 3.9.0-15 for disk api) which unfortunately lead to a breakage in creating new scheduled scrubs (in the consequent 3.9.1 stable release) and then during further necessary changes in the share api in 3.9.2’s development cycle (just finished) we had a similar regression in scheduled snapshots.

The scheduled scrub issue caused by the pool api change (towards end of 3.9.1 dev cycle):

and it’s fix in 3.9.2 dev cycle:

And on the Snapshot side we have:
The scheduled snapshot issue caused by the share api change (during 3.9.2 dev cycle):
https://github.com/rockstor/rockstor-core/issues/1809
and it’s fix in the same 3.9.2 dev cycle:
https://github.com/rockstor/rockstor-core/pull/1812

Hopefully the main issue here is that we have 3.9.2 stable out but a fair bit prior to the usual announcement / stable subscriber-mailshot that might otherwise contain such advisory requirements. A rather unforeseen ‘real life’ delay on that one unfortunately: but should be published shortly.

I have updated @ScarabMonkey linked issue with a few more details as I currently believe it to be a duplicate of the above linked snapshot issue/pr.

Linking to the associated scheduled scrub thread where @kbogert diagnosed the api change as the culprit:

We have confirmation in that thread, also by @kbogert, that the released fix was as intended post scheduled scrub task re-creation.

Hope that helps and clears up the rather confusing schedule scrub / snapshot issues.