Retrieving serial # from NVMe device fails

phillxnet · July 4, 2016, 7:40pm

@f_l_a Just as a heads up, as I know you have now re-installed on a non nvme device now, but as of Rockstor 3.8-14.02 testing channel updates all smart calls on nvme devices and devices that have no serial should now be blocked. So at least those smartctl --info messages should no longer occur on these devices. We can easily remove this once the support in in place in smartmontools.

Not the main problem you encountered but at least it’s something.

Also if you fancy trying to patch in serial retrieval for nvme for the time being, prior to udev and co in CentOS getting updated the place to do it may well be in the get_disk_serial() function in src/rockstor/system/osi.py:

github.com

rockstor/rockstor-core/blob/master/src/rockstor/system/osi.py#L820-L839


      
          def convert_netmask(bits):
              # convert netmask bits into ip representation
              bits = int(bits)
              mask = 0
              for i in range(32 - bits, 32):
                  mask |= 1 << i
              return inet_ntoa(pack(">I", mask))
          
          
          def net_config_helper(name):
              config = {}
              o, e, rc = run_command([NMCLI, "-t", "c", "show", name], throw=False)
              if rc == 10:
                  return config
              for l in o:
                  l = l.strip()
                  if "method" in config:
                      if config["method"] == "auto":
                          # dhcp
                          if re.match("DHCP4.OPTION.*ip_address = .+", l) is not None:

It is called whenever lsblk can’t retrieve a serial and maybe soon via:

it may be used by default.

There is already a patch in place, as indicated by the “Additional personality” comment, to deal with md devices as as special case so maybe an additional ‘personality’ could be added to deal with nvme serial retrieval via the method you indicated.

Just a thought.