Creating SMB Share

phillxnet · September 15, 2017, 10:08am

@seppolind Welcome to the Rockstor community.

Thanks for reporting this. As it goes we have already fixed this (in pend release code) by way of the following prior report:

github.com/rockstor/rockstor-core

Unable to create Samba export

opened 09:43PM - 12 Sep 17 UTC

closed 02:04AM - 15 Sep 17 UTC

aherbach88

bug

When trying to create a share in 3.9.1-10 I get an error of "Unknown internal er…ror doing a POST to /api/samba" in the WebUI, while tailing the rockstor log, I get the following error (my share is called systems): [12/Sep/2017 14:33:53] ERROR [storageadmin.middleware:33] invalid literal for int() with base 10: 'systems' Traceback (most recent call last): File "/opt/rockstor/eggs/Django-1.8.16-py2.7.egg/django/core/handlers/base.py", line 132, in get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File "/opt/rockstor/eggs/Django-1.8.16-py2.7.egg/django/views/decorators/csrf.py", line 58, in wrapped_view return view_func(*args, **kwargs) File "/opt/rockstor/eggs/Django-1.8.16-py2.7.egg/django/views/generic/base.py", line 71, in view return self.dispatch(request, *args, **kwargs) File "/opt/rockstor/eggs/djangorestframework-3.1.1-py2.7.egg/rest_framework/views.py", line 452, in dispatch response = self.handle_exception(exc) File "/opt/rockstor/eggs/djangorestframework-3.1.1-py2.7.egg/rest_framework/views.py", line 449, in dispatch response = handler(request, *args, **kwargs) File "/opt/rockstor/eggs/Django-1.8.16-py2.7.egg/django/utils/decorators.py", line 145, in inner return func(*args, **kwargs) File "/opt/rockstor/src/rockstor/storageadmin/views/samba.py", line 135, in post request.data['shares']] File "/opt/rockstor/src/rockstor/storageadmin/views/share.py", line 72, in _validate_share share = Share.objects.get(id=sid) File "/opt/rockstor/eggs/Django-1.8.16-py2.7.egg/django/db/models/manager.py", line 127, in manager_method return getattr(self.get_queryset(), name)(*args, **kwargs) File "/opt/rockstor/eggs/Django-1.8.16-py2.7.egg/django/db/models/query.py", line 325, in get clone = self.filter(*args, **kwargs) File "/opt/rockstor/eggs/Django-1.8.16-py2.7.egg/django/db/models/query.py", line 679, in filter return self._filter_or_exclude(False, *args, **kwargs) File "/opt/rockstor/eggs/Django-1.8.16-py2.7.egg/django/db/models/query.py", line 697, in _filter_or_exclude clone.query.add_q(Q(*args, **kwargs)) File "/opt/rockstor/eggs/Django-1.8.16-py2.7.egg/django/db/models/sql/query.py", line 1310, in add_q clause, require_inner = self._add_q(where_part, self.used_aliases) File "/opt/rockstor/eggs/Django-1.8.16-py2.7.egg/django/db/models/sql/query.py", line 1338, in _add_q allow_joins=allow_joins, split_subq=split_subq, File "/opt/rockstor/eggs/Django-1.8.16-py2.7.egg/django/db/models/sql/query.py", line 1209, in build_filter condition = self.build_lookup(lookups, col, value) File "/opt/rockstor/eggs/Django-1.8.16-py2.7.egg/django/db/models/sql/query.py", line 1102, in build_lookup return final_lookup(lhs, rhs) File "/opt/rockstor/eggs/Django-1.8.16-py2.7.egg/django/db/models/lookups.py", line 105, in __init__ self.rhs = self.get_prep_lookup() File "/opt/rockstor/eggs/Django-1.8.16-py2.7.egg/django/db/models/lookups.py", line 143, in get_prep_lookup return self.lhs.output_field.get_prep_lookup(self.lookup_name, self.rhs) File "/opt/rockstor/eggs/Django-1.8.16-py2.7.egg/django/db/models/fields/__init__.py", line 727, in get_prep_lookup return self.get_prep_value(value) File "/opt/rockstor/eggs/Django-1.8.16-py2.7.egg/django/db/models/fields/__init__.py", line 985, in get_prep_value return int(value) ValueError: invalid literal for int() with base 10: 'systems'

which was addressed by the following pull request:

github.com/rockstor/rockstor-core

unable to create samba export. Fixes #1813

rockstor:master ← phillxnet:1813_Unable_to_create_Samba_export

opened 06:12PM - 14 Sep 17 UTC

phillxnet

+38 -38

Updates the samba share export create UI template to pass share id not name to b…e in line with recent share api changes. A second commit in this pr addresses tab char removal and a handlebars space issue which is suspected to be cosmetic only. Most prior hand formatting of the file is maintained as machine re-formatting failed to understand the handlebar helper associated with a conditional clause within a div definition. Fixes #1813 Testing involved first reproducing #1813 as reported by @aherbach88. Post pr the samba share export was successfully added to the displayed list and no UI or log errors were reported. No similar issue was observed with a quick test of NFS, SFTP, and AFP share exports. Ready for review.

So pending final tests of the resulting merged code it should be release in the next testing channel update. Keep an eye on the following thread which details the current (as of writing) testing channel releases:

Hope that helps.

Note that testing channel is expected to break from time to time and feedback such as yours is greatly valued. There are some major changes ‘under the hood’ ongoing currently which inevitably lead to issues such as this but that is what the testing channel is for. But the upside is that once the dust has settled there will be more potential for magic (read useful features/flexibility). Thanks for your contribution and please do report any other issues you find.