Disk Activity question

wdc · December 3, 2022, 4:59pm

What does it mean to sort the disks by “draft”? I’ve wondered for some time and am finally getting around to asking.

Thank you.

wdc · December 9, 2022, 1:07am

Well here’s the good news… I was sure that this is one of those things that I ought to know. That’s good news? Yes, it is good news - others don’t know either- I’m in good company!
As I read this back to myself, I see how it could be interpreted badly. Rest assured, I’m really feeling good here! No complaints!

phillxnet · December 11, 2022, 10:32am

@wdc Hello again.
Re:

and

Yes, me too. .

The code that does this widget is here:

github.com

rockstor/rockstor-core/blob/0249f5283203461d71093447611c762901f6f378/src/rockstor/storageadmin/static/storageadmin/js/views/dashboard/disk_utilization.js#L464-L496


sortDisks: function() {


    var _this = this;
    var tmp = _.map(_.keys(_this.disksData), function(k) {
        return _this.disksData[k][_this.dataLength - 1];
    });


    var sort_attr = _this.selectedAttr;
    if (sort_attr == 'best_draft') {
        var selected_top = [];
        for (var i = 0; i < Object.keys(tmp).length; i++) {
            _.each(_this.best_draftSort, function(d) {
                var sorted = _.sortBy(tmp, function(k) {
                    return k[d];
                }).reverse();
                if (!_.contains(selected_top, sorted[i].name) && selected_top.length < _this.numTop) {
                    selected_top.push(sorted[i].name);
                }
            });
        }

This file has been truncated. show original

Click to see the whole function.

Contributions on a write-up are, as always, welcome :).

This was contributed by the prolific contributor at the time @Flyer. I’m afraid my own JS is kept to a bare minimum: for good reason.

Hope that helps.

Hooverdan · December 11, 2022, 10:27pm

Looking further up in the JS template, it seems the sort order is defined by this:

github.com

rockstor/rockstor-core/blob/0249f5283203461d71093447611c762901f6f378/src/rockstor/storageadmin/static/storageadmin/js/views/dashboard/disk_utilization.js#L70-72


// dataLength
// each value is of the format of the data returned by the api
// see genEmptyDiskData for an example of this format
this.disksData = {};
this.disks = new DiskCollection();
this.disks.pageSize = RockStorGlobals.maxPageSize;


this.topDisks = [];
this.selectedDisk = null;


this.best_draftSort = ['reads_completed', 'writes_completed', 'sectors_read', 'sectors_written', 'ms_ios', 'ms_writing', 'ms_reading'];
this.selectedAttr = 'best_draft';


this.SingleDiskChart = null;
this.SingleDiskChartOptions = {
    animation: false,
    responsive: false,
    title: {
        display: true,
        text: '',
        padding: 5,

implying that reads completed is the top criterion here.

wdc · December 11, 2022, 11:44pm

I found that as well and was trying to figure out if that’s how it traced through the code (and I’m not a jscript guy either). Based on that, I think I would call it a measure of “disk activity” as it is a variety of IO measures exclusive of the amount of data being moved).