Failed to import any pool on this device(5) caused by space_cache

[g6094199 (S.)]

Brief description of the problem

Cant import mdraid5 with btrfs on top

Detailed step by step instructions to reproduce the problem

The import cant be done cause the btrfs is using space_cache=v2. After cleaning space cache the import works!
we’re at kernel 4.12@rockstor right now. Imho space_cache=v2 is mature enough to be used. So plz add support for the space_cache=v2 mount option! Even make it default for new installs.
THX!

Web-UI screenshot

Error Traceback provided on the Web-UI

Traceback (most recent call last):
File “/opt/rockstor/src/rockstor/storageadmin/views/disk.py”, line 679, in _btrfs_disk_import
p_info = get_pool_info(disk_name)
File “/opt/rockstor/src/rockstor/fs/btrfs.py”, line 110, in get_pool_info
run_command([BTRFS, ‘fi’, ‘label’, dpath, label])
File “/opt/rockstor/src/rockstor/system/osi.py”, line 119, in run_command
raise CommandException(cmd, out, err, rc)
CommandException: Error running a command. cmd = /sbin/btrfs fi label /dev/disk/by-id/md-uuid-43120cf2:0a85a0ba:dfde4ac7:9a94f66c dbf8037d-875f-49f3-bcfd-80fc4e2ec5bc. rc = 255. stdout = [‘’]. stderr = [“couldn’t open RDWR because of unsupported option features (3).”, ‘’]


[phillxnet (Philip Guyton)]

@g6094199 Hello again.

@g6094199

The import cant be done cause the btrfs is using space_cache=v2. After cleaning space cache the import works!

Nice find, thanks for posting.

@g6094199

… we’re at kernel 4.12@rockstor right now. Imho space_cache=v2 is mature enough to be used. So plz add support for the space_cache=v2 mount option!

We are only just at 4.12 kernel as of current testing channel release:

Dev log for 3.9.2

Hello Boys and Girls, 3.9.1-4 is now available. A bug in config backup and restore is fixed. Two more bugs in user management are also fixed. This one is also a Phillip’date like the last three. Thank you @phillxnet. As some of you are waiting, I did manage to test the 4.12 kernel and added it along with btrfs-progs 4.12. Enjoy the update and please test away!

But I agree that the inclusion of space_cache=v2 is a good idea:
https://github.com/rockstor/rockstor-core/issues/1810

@g6094199

Even make it default for new installs.

This is something I can’t agree with however. We essentially follow the lead re btrfs devs on all defaults so upon our elrepo kernel-ml version adopting this by default then as do we. I don’t think it is wise to deviate from the developer ascribed defaults. Apologies if I have the wrong end of the stick here.

Hope that helps and thanks for your ongoing contribution.

[g6094199 (S.)]

he phill,

i cant understand to follow mainline…i can live with that

THX 4 adding!

[g6094199 (S.)]

Hi,

another suggestion: How about giving the user the opportunity to choose with space_cache option to use?

a dropdown like for the compression option. the dropdown must have at least 3 settings space_cache, space_cache=v2 and clear_cache (this must be set with option no_space_cache, so users can safely switch from space_cache=v1 to space_cache=v2 without breaking anything)