phillxnet
(Philip Guyton)
July 9, 2016, 9:23pm
2
@dwnomad Welcome to the Rockstor community. And your timing on trying out Rockstor is rather unfortunate I must say. Thanks for reporting this. You were rather unlucky on this one as the update that broke this has only just been release yesterday:
Hello Everyone,
Rockstor 3.8-14.03 is now available! Like the previous two updates in this new cycle, this is also a big one. @Flyer has contributed a pincard based password recovery system for users including root(with a bit of extra security). The system is pretty interesting to me and something security conscious users may like a lot! The UI side of it has the signature @Flyer snappy-ness which is pretty cool.
I made the samba service independent of rockstor-bootstrap which was giving grief…
and we have an in progress issue on GitHub on the same:
opened 09:17AM - 09 Jul 16 UTC
closed 08:21PM - 10 Jul 16 UTC
See thread here from another user: https://forum.rockstor.com/t/3-8-14-03-broke-… samba/1726
```
Traceback (most recent call last):
```
File "/opt/rockstor/src/rockstor/rest_framework_custom/generic_view.py", line 40, in _handle_exception
yield
File "/opt/rockstor/src/rockstor/smart_manager/views/samba_service.py", line 44, in get
config = get_global_config()
File "/opt/rockstor/src/rockstor/system/samba.py", line 179, in get_global_config
config[fields[0].strip()] = fields[1].strip()
IndexError: list index out of range
And another forum thread with other reports of the same issue:
I upgraded to 3.8-14.03 on two different Rockstor servers. Both broke Samba. The following is the error received when going to the Samba page:
Traceback (most recent call last):
File “/opt/rockstor/src/rockstor/rest_framework_custom/generic_view.py”, line 40, in _handle_exception
yield
File “/opt/rockstor/src/rockstor/smart_manager/views/samba_service.py”, line 44, in get
config = get_global_config()
File “/opt/rockstor/src/rockstor/system/samba.py”, line 179, in get_global_confi…
And finally there is a pending fix that should soon receive review / testing:
rockstor:master
← phillxnet:1385_3.8-14.03_broke_Samba_config
opened 08:55PM - 09 Jul 16 UTC
@schakrava I've run out of time on this one for today but to ease hand over I've… created this pr.
However I think with this pr the new samba config global import / update mechanism is now working as intended. And is best tested by yourself in this case anyway.
N.B. Very little (next to none) testing but parser now appears to import existing [global] config correctly and also appears to re-write this config correctly.
So over to you for review / testing.
Please see issue #1385 for the development history that lead to this issue.
So hopefully this should be fixed in the next testing channel update, or at least soon there after.
1 Like