Mocking considerations in tests?

General
2

@aremiaskfa Hello again:
Re:

Indeed there is. See:

rleap15-4:~ # grep -R "mock" /opt/rockstor/src/

resulting in:

/opt/rockstor/src/rockstor/fs/tests/test_btrfs.py:from mock import patch
/opt/rockstor/src/rockstor/fs/tests/test_btrfs.py:        self.mock_run_command = self.patch_run_command.start()
/opt/rockstor/src/rockstor/fs/tests/test_btrfs.py:        # # setup mock patch for is_mounted() in fs.btrfs
/opt/rockstor/src/rockstor/fs/tests/test_btrfs.py:        # self.mock_is_mounted = self.patch_is_mounted.start()
...

Above trimmed as too long for forum post (several hundred lines).

or:

grep -R "mock" /opt/rockstor/src/ | wc -l
815

The in-code ‘test’ mode we have in smart is unique in that respect. At the time we needed a quick and dirty but extremely robust way assess user submitted smart results. This was that way, along with the associated bash script referenced by me here:

To run all our current tests just do the following (long hand for clarity):

export DJANGO_SETTINGS_MODULE=settings
cd /opt/rockstor/src/rockstor/
poetry run django-admin test

which should give you approximately:

Creating test database for alias 'default'...
Creating test database for alias 'smart_manager'...
System check identified no issues (0 silenced).
............................................................................................................................................................................................................................................
----------------------------------------------------------------------
Ran 236 tests in 22.670s

OK
Destroying test database for alias 'default'...
Destroying test database for alias 'smart_manager'...

Or use a verbose test option like:

rleap15-4:/opt/rockstor/src/rockstor # poetry run django-admin test -v2
Creating test database for alias 'default' ('test_storageadmin')...
Operations to perform:
  Synchronize unmigrated apps: djhuey, messages, pipeline, rest_framework, staticfiles
  Apply all migrations: admin, auth, contenttypes, oauth2_provider, sessions, sites, smart_manager, storageadmin
Synchronizing apps without migrations:
...

Above trimmed as too long for forum post.

This is I’m afraid another side effect of our recent non trivial change in build system from buildout to poetry:

making our current developer docs outdated and in need of a refresh.

Hope that helps and again apologies for our behind the times docs in both user and developer areas here, but all in good time and any assistance, such as you have yourself already been involved in, is always welcome.

Thanks again for yet more usefull observations. It all helps with seeing where we have gaps across the project. More eyes and all.

2 Likes