SMART not supported?

phillxnet · January 26, 2023, 5:40pm

@aremiaskfa Hello again, and thanks for chasing this one down.

Re:

Yes, that looks to be correct; at least as far as you have tracked this down before the smart.available() discovery anyway.

It very much looks like you are getting to the root of this one actually.
Re:

The only developer docs we have for these related functions are within their docstrings. I think the following source file and location should point you in the right direction:

github.com

rockstor/rockstor-core/blob/5ea4b206d068cf095277b0fee6238d71d16dadb3/src/rockstor/system/smart.py#L328-L350


      
          def available(device, custom_options="", test_mode=TESTMODE):
              """
              Returns boolean pair: true if SMART support is available on the device and
              true if SMART support is enabled.
              Used by update_disk_state in views/disk.py to assess smart status
              :param device:
              :return: available (boolean), enabled (boolean)
              """
              if not test_mode:
                  o, e, rc = run_command(
                      [SMART, "--info"] + get_dev_options(device, custom_options)
                  )
              else:  # we are testing so use a smartctl --info file dump instead
                  o, e, rc = run_command([CAT, "/root/smartdumps/smart--info.out"])
              a = False
              e = False
              for i in o:
                  # N.B. .* in pattern match to allow for multiple spaces
                  if re.match("SMART support is:.* Available", i) is not None:
                      a = True

This file has been truncated. show original

Which is under (a part/file of) the system module (note the init.py within the system dir).

From the file you have been looking at we have the following import from elsewhere in our own code:

github.com

rockstor/rockstor-core/blob/5ea4b206d068cf095277b0fee6238d71d16dadb3/src/rockstor/storageadmin/views/disk.py#L37


      
              pool_raid,
              get_dev_pool_info,
              set_pool_label,
              get_devid_usage,
          )
          from storageadmin.serializers import DiskInfoSerializer
          from storageadmin.util import handle_exception
          from share_helpers import import_shares, import_snapshots
          from django.conf import settings
          import rest_framework_custom as rfc
          from system import smart
          from system.luks import (
              luks_format_disk,
              get_unlocked_luks_containers_uuids,
              get_crypttab_entries,
              update_crypttab,
              native_keyfile_exists,
              establish_keyfile,
              get_open_luks_volume_status,
          )
          from system.osi import (

And so we get access to “smart” and all it’s goodies as we have defined them: smart.available is thus usable within this views/disk.py file.

And if you do fancy taking your findings to a pull request stage, then note that we don’t as-yet have any unit tests for this part (smart) of the system module:

It may very well be a good time/exercise to add some coverage to this area if it turns out that what we need here is an augmentation in our parsing to decern smart availability. But it may also be that nvme output is quite different. Let us know how your experimentation goes.

Also note that we have an ability to submit problematic smart output via the following shell script:

github.com

rockstor/rockstor-core/blob/testing/src/rockstor/scripts/dump-smart.sh

#!/bin/bash
#
# Simple shell script to dump the raw smartctl command output as used internally
# by Rockstor prior to parsing for Web-UI accessible SMART info.
#
# Intended as an aid to reporting SMART parsing issues on:
# https://forum.rockstor.com/
#

# Check number of script arguments.
if [ "$#" -ne 1 ]; then
    echo
    echo "Please supply a single device name using the /dev/sdX or /dev/disk/by-id reference"
    echo "N.B. Use the base device - not a partition reference."
    echo "eg $0 /dev/disk/by-id/ata-ST3160021AS_5JS1HNX9"
    echo
    exit
fi

DEVNAME=$1

This file has been truncated. show original

So it would be helpful to post the output of that script, for the given NVME device to our support email as we would then have access to this particular smart output. The testing mode you see referenced in smart.py is intended for developers to be able to test our code on systems they don’t have direct access to. I unfortunately don’t have access to a real nvme currently, but we do have some in the ‘team’ : but as always it’s a matter of prioritising time. So do, if you can, keep chipping away on this one as I think you are running down a new area of development for us. As stated we have never supported nvme smart and their output may present some new challenges.

Hope that helps, and thanks again for potentially extending our nvme smart capabilities.