August 5, 2016, 8:26am
Hey guys, I have created a new share and set up a new snapshot task in the task scheduler as well as enabling the shadow copies, everything is working fine no worries a part from the incorrect times of the previous versions on the samba share.
Here is the snapshots on RockStor with the correct times.
This is the incorrect times on the previous versions
I made sure my ntp server is set correctly as it shows the right times in the snapshots on RockStor webui. I have tried to restart the smb service, rebooting RockStor but no luck. It seems am missing something but I can’t figure it out.
August 5, 2016, 9:31am
that’s a really strange behaviour (previously had some tests on shadow copies without problems).
Are Rockstor server and your client on same time zone?? ( looking to your snapshots it seems ok )
Maybe we can move from local time snapshots/shadow copies to utc timings (there’s an open issue on it)
02:44PM - 09 Apr 16 UTC
09:04PM - 30 Aug 16 UTC
You decided to save the automatic share snapshots in a format like
The timestamp format is local time, as configured during the installation.
By default, samba is set to expect UTC here, as described in the doc here:
This leads to an time offset in the windows prevous version tab by the differnce of the user local time including DST.
`shadow:localtime = yes`
to each share entry in smb.conf fixes this. Please add this entry.
Anyway i would recommend to use the default naming "@GMT-%Y.%m.%d-%H.%M.%S"
for the snapshots and do the formatting in the GUI, with timestamp timezone translation.
Having timestamps in local time will lead to further problems if the user changes the machine timezone and so on. Thats probably the reason for v_shadow_copy's default settings.
Anyone else having some problem??
August 5, 2016, 10:42am
@Flyer, yes mate they are on the same time zone, am not really sure how to change the time zone since I don’t have an option to change it after the installation!!!
August 5, 2016, 10:56am
One minute test:
storage -> samba -> edit your shadow copies share and add this on custom configuration box:
shadow:localtime = yes
While enabling shadow copies current snapshot format is well defined with
shadow:format, so win machines should understand it except for local time / utc-gtm time
Let us know if this solves it
August 5, 2016, 11:23am
Cheers mate for the super quick replay
, will test it and will let you know thanks again.
August 5, 2016, 11:35am
Seriously mate you awesome all fixed now times are correct
Was there any reason for the time to go wonky like that?? If there is no answer its cool am glad it was simple and it worked
August 5, 2016, 12:56pm
@Mahmoud87 thanks for your testing!, going to open asap a pull request on github closing issue by fkurth!! (this test confirms we can just add samba local time flag and avoid rewriting snapshots code for utc )
01:22PM - 05 Aug 16 UTC
Related to #1252
My opinion to @phillxnet and @schakrava
Having all in UTC/GM
… T probably would be the perfect solution, but solving just adding localtime param it's easier and less expensive:
- moving to gmt probably would require some snapshots code rewrite
- having old snapshots with local time and new ones with gmt will mess all (think about this pr like a "conservative patching" letting us not to write a complex script to allign old snaps format with new snaps)
August 5, 2016, 1:09pm
Terrific mate and hopefully will get fixed in the next builds. Thanks again