[SOLVED] Wrong tagging in SMB.conf

He!

If found some formating problem and maybe this is an issue depending on how its internally handeled.
when you join an ADS domain, in the smb.conf the ending tag of the equivalent part is wrongly tagged with “BEGIN:…” where it should be “END:…”

Detailed step by step instructions to reproduce the problem

####BEGIN: Rockstor ACTIVE DIRECTORY CONFIG####
security = ads
realm = xxxx.local
template shell = /bin/sh
kerberos method = secrets and keytab
winbind use default domain = false
winbind offline logon = true
winbind enum users = yes
winbind enum groups = yes
idmap config * : backend = tdb
idmap config * : range = 1000000 - 1999999
idmap config xxx : backend = rid
idmap config xxx : range = 10000 - 999999
####BEGIN: Rockstor ACTIVE DIRECTORY CONFIG####

Good evening @g6094199,
nice catch!
Fortunately it’s a really minor issue (style) not affecting Samba & Rockstor functionality

Here the open issue

Here new PR fixing it :wink:

Thanks again for reporting it!
Mirko

1 Like